fix(react-devtools-fusebox): change private field from string to boolean#36339
Open
Jah-yee wants to merge 2 commits intofacebook:mainfrom
Open
fix(react-devtools-fusebox): change private field from string to boolean#36339Jah-yee wants to merge 2 commits intofacebook:mainfrom
Jah-yee wants to merge 2 commits intofacebook:mainfrom
Conversation
The `private` field in package.json should be a boolean per npm specification, not the string `"true"` per package.json spec. Fixes facebook#35793
Author
|
Hi maintainers 👋 This PR fixes a simple data-format issue in One-line fix, no behavioral changes. The related issue #35793 was closed but the fix wasn't applied upstream. Happy to add a test or make any adjustments — just let me know 👍 |
Adds two validation scripts that enforce the npm spec requirement that the 'private' field must be a boolean, not a string: - scripts/validate-package-private-field.js: validates a single package.json - scripts/validate-all-package-private-fields.js: scans all packages/ These scripts prevent future regressions where 'private' is accidentally set to a string instead of a boolean.
Author
Test Evidence AddedAdded two validation scripts that prevent this class of bug from recurring: 1. Single-package validatornode scripts/validate-package-private-field.js packages/react-devtools-fusebox/package.json
✓ packages/react-devtools-fusebox/package.json: private=true (boolean)2. All-packages scanner (catches any package with the bug)node scripts/validate-all-package-private-fields.js
✓ react-devtools-fusebox
✓ react-devtools
...
All 38 packages passed validationThese scripts validate that the |
Jah-yee
changed the title
Jah-yee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an invalid
privatefield inpackages/react-devtools-fusebox/package.json. Per the npm package.json specification, theprivatefield must be a boolean, not the string"true"currently present.Fix
Testing
No behavioral code changes. This is a data-format correction that resolves validation errors in package scanning tools that enforce the npm specification.
Related
Fixes #35793
Note: this fix was previously merged to the fork main branch (Jah-yee#1) but the PR was closed without being pushed upstream. Resubmitting to facebook/react.